Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intended behavior of empty samplesheet with missing sections #108

Open
golharam opened this issue Nov 30, 2020 · 1 comment
Open

Intended behavior of empty samplesheet with missing sections #108

golharam opened this issue Nov 30, 2020 · 1 comment
Labels

Comments

@golharam
Copy link
Contributor

One of our lab operators provided an empty samplesheet intending to fill it out later, but never did. As a result, this run made it into our pipeline where we use this package to read the samplesheet. The samplesheet provided is:

[Data],,,,,,,,,
Sample_ID,Sample_Name,Sample_Plate,Sample_Well,I7_Index_ID,index,I5_Index_ID,index2,Sample_Project,Description

No other sections, and no samples. When I loaded this samplesheet using

from sample_sheet import SampleSheet as IlluminaSampleSheet
ss = IlluminaSampleSheet(sample_sheet_path)

no error was thrown. Is that the intended behavior?

@clintval
Copy link
Owner

I believe the other mandatory section headers must be present even in the case of a truly empty sample sheet. I am currently re-working how validations are performed to make them modular and user-controlled (and user-extended) to solve #96 and #108. Once that's ready, it will be far easier to turn on/off and extend sample sheet validations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants