Drop type-hints from assoc-conversion to work around AOT issue
#69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this function is usually not called at runtime, the reflection performance penalty should be tolerable. Fixes clj-commons#68
|
Does it also fix #34? |
KingMob
requested changes
Jan 25, 2023
There was a problem hiding this comment.
Can you make Eastwood stop complaining about the changes? https://github.com/jonase/eastwood#ignored-faults
Pretty sure it would (this patch was derived from the workaround in that ticket's description). However, according to #34 (comment) it wasn't reproducible anymore in that particular context so I didn't try anymore.
Done! |
KingMob
approved these changes
Jan 27, 2023
|
Indeed, that's unfortunate 🤷 Note that I don't have merge rights myself here so you'll have to do the honors 🙂 |
|
Dammit, let me see about adding you as a contributor |
|
@DerGuteMoritz Try merging now |
|
Thanks! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this function is usually not called at runtime, the reflection performance penalty should be tolerable.
Fixes #68