-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for IE #44
Comments
I don't really plan to support browsers without CSS Variables support. Are you sure ClojureScript perf is fine on IE <11? Runtime styles may make it even worse. |
Ah that's a bummer. Would it be a lot of work to support this? Unfortunately it's not <11 i'm worried about; even 11 doesn't support css vars (thanks to Edge, probably). I'm not positive how you're converting a map into a string of css rules. But, it doesn't seem like a lot of extra work to make sure to also add a |
I have to support an IE11 client, unfortunately. I am going to fork this library and poke around for where I can best insert this change without breaking anything. If you had any pointers on where to start and what effects I might want to watch out for, that would be much appreciated :) |
Essentially you have to move macros into runtime. IE11 doesn’t have the best JS VM so I’m not sure if perf is going to be fine there. I’d make a wrapper on top of existing JS libraries instead. |
Once again, great job on this lib. It's nearly-exactly what I would have written myself, so thanks for saving a ton of time.
It would be great to support later IE versions. Currently IE doesn't support css-vars. You can really easily get around this by outputting both a var and a fallback style.
I'm not sure what the implementation implications are for this change, so some input would be great.
The text was updated successfully, but these errors were encountered: