Skip to content

Commit

Permalink
CLI - Remove deprecated use of the --project-path flag (#915)
Browse files Browse the repository at this point in the history
Co-authored-by: Zeke Foppa <github.com/bfops>
Co-authored-by: Zeke Foppa <[email protected]>
  • Loading branch information
bfops and bfops authored Dec 30, 2024
1 parent da0f83b commit 43ad8be
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 11 deletions.
6 changes: 1 addition & 5 deletions crates/cli/src/subcommands/generate/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -122,11 +122,7 @@ pub async fn exec(config: Config, args: &clap::ArgMatches) -> anyhow::Result<()>
};
module
} else {
let wasm_path = if !project_path.is_dir() && project_path.extension().map_or(false, |ext| ext == "wasm") {
println!("Note: Using --project-path to provide a wasm file is deprecated, and will be");
println!("removed in a future release. Please use --bin-path instead.");
project_path.clone()
} else if let Some(path) = wasm_file {
let wasm_path = if let Some(path) = wasm_file {
println!("Skipping build. Instead we are inspecting {}", path.display());
path.clone()
} else {
Expand Down
6 changes: 1 addition & 5 deletions crates/cli/src/subcommands/publish.rs
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,7 @@ pub async fn exec(config: Config, args: &ArgMatches) -> Result<(), anyhow::Error
));
}

let path_to_wasm = if !path_to_project.is_dir() && path_to_project.extension().map_or(false, |ext| ext == "wasm") {
println!("Note: Using --project-path to provide a wasm file is deprecated, and will be");
println!("removed in a future release. Please use --bin-path instead.");
path_to_project.clone()
} else if let Some(path) = wasm_file {
let path_to_wasm = if let Some(path) = wasm_file {
println!("Skipping build. Instead we are publishing {}", path.display());
path.clone()
} else {
Expand Down
2 changes: 1 addition & 1 deletion crates/client-api/src/routes/tracelog.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@ use serde::Deserialize;
use tempfile::TempDir;

use spacetimedb::address::Address;
use spacetimedb::replica_context::ReplicaContext;
use spacetimedb::db::Storage;
use spacetimedb::hash::hash_bytes;
use spacetimedb::host::instance_env::InstanceEnv;
use spacetimedb::host::tracelog::replay::replay_report;
use spacetimedb::host::Scheduler;
use spacetimedb::replica_context::ReplicaContext;
use spacetimedb_lib::Identity;

use crate::{log_and_500, ControlStateReadAccess, NodeDelegate};
Expand Down

1 comment on commit 43ad8be

@github-actions
Copy link

@github-actions github-actions bot commented on 43ad8be Dec 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Criterion benchmark results

Error when comparing benchmarks: Couldn't find AWS credentials in environment, credentials file, or IAM role.

Caused by:
Couldn't find AWS credentials in environment, credentials file, or IAM role.

Please sign in to comment.