Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STABILITY] Specific Timestamp type in the SDK #1375

Open
cloutiertyler opened this issue Jun 11, 2024 · 4 comments · May be fixed by #1836
Open

[STABILITY] Specific Timestamp type in the SDK #1375

cloutiertyler opened this issue Jun 11, 2024 · 4 comments · May be fixed by #1836
Assignees
Labels
abi-break A PR that makes an ABI breaking change api-break A PR that makes an API breaking change

Comments

@cloutiertyler
Copy link
Contributor

Mario:
Then does this means adding chrono? Trying of use u64 instead internally is a footgun similar to how bool in SQLite is 1/0 (ie: Lets add proper date types, it also matters to match sQL spec)

If you use a timestamp in a table or as a reducer argument, then its going to generate a u64 which is unintuitive.

@mamcx mamcx self-assigned this Jul 12, 2024
@mamcx
Copy link
Contributor

mamcx commented Jul 12, 2024

I agree is desirable to have concrete types. The issue is that dates have several:

https://docs.rs/chrono/latest/chrono/

This probably require a proposal

@cloutiertyler
Copy link
Contributor Author

I'm going to leave this open, but I suspect this should really be defined by: https://github.com/clockworklabs/SpacetimeDBPrivate/issues/839

Wherein we would just choose to use a u64 or something so as to not impose our own opinion about how you should represent timestamps in a given language.

@cloutiertyler cloutiertyler assigned gefjon and unassigned mamcx Jul 29, 2024
@joshua-spacetime joshua-spacetime linked a pull request Oct 31, 2024 that will close this issue
3 tasks
@gefjon
Copy link
Contributor

gefjon commented Oct 31, 2024

Current status: A draft PR exists in SpacetimeDB, which needs a rebase. I opened a corresponding TypeScript SDK PR, which needs testing. We still need a C# SDK PR, which should essentially just be re-generating the Client API bindings, but we intend to wait on that until the C# SDK calms down a bit.

@joshua-spacetime joshua-spacetime added abi-break A PR that makes an ABI breaking change api-break A PR that makes an API breaking change labels Dec 16, 2024
@joshua-spacetime
Copy link
Collaborator

Tentatively downgrading this to P2 for now as per conversation with @gefjon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abi-break A PR that makes an ABI breaking change api-break A PR that makes an API breaking change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants