Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI - dns subcommand becomes rename #1694

Merged
merged 9 commits into from
Jan 7, 2025
Merged

CLI - dns subcommand becomes rename #1694

merged 9 commits into from
Jan 7, 2025

Conversation

bfops
Copy link
Collaborator

@bfops bfops commented Sep 10, 2024

Description of Changes

The dns subcommand is half-finished. We are simplifying it for now: it is now just spacetime rename.

API and ABI breaking changes

This removes several dns subcommands, and renames dns set-name to just rename.

Expected complexity level and risk

2

Testing

Existing CI has been updated (see https://github.com/clockworklabs/SpacetimeDB/pull/1694/files#diff-c05a1f93f7bbe434d3be3d080b9aff1750af73d7e1fc2870a8a9c9c9550e89e9).

@bfops bfops added release-any To be landed in any release window abi-break A PR that makes an ABI breaking change CLI only This change only affects the CLI behavior labels Sep 10, 2024
@cloutiertyler
Copy link
Contributor

cloutiertyler commented Nov 23, 2024

I'm recommending we keep this as a P1 because if we don't then we need the docs to explain what dns is and all that and we don't want to bother with that because it's going to be confusing since it's not literally dns at this point, although we do want databases to be accessible eventually as dbname.mainnet.spacetimedb.com.

@gefjon
Copy link
Contributor

gefjon commented Dec 30, 2024

Tyler says: we should have a spacetime database rename command (or spacetime rename? Like what we do for servers.) which renames a database. We should call these "database names," and not use the word "DNS."

@bfops bfops marked this pull request as ready for review January 3, 2025 15:08
@bfops bfops requested a review from cloutiertyler as a code owner January 3, 2025 15:08
@bfops bfops changed the title CLI - Remove dns subcommand CLI - dns subcommand becomes rename Jan 3, 2025
@cloutiertyler
Copy link
Contributor

Could you add a test for this? Or point to the specific CI test that tests this command?

@bfops
Copy link
Collaborator Author

bfops commented Jan 3, 2025

Could you add a test for this? Or point to the specific CI test that tests this command?

https://github.com/clockworklabs/SpacetimeDB/pull/1694/files#diff-c05a1f93f7bbe434d3be3d080b9aff1750af73d7e1fc2870a8a9c9c9550e89e9 has been updated

Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See single comment.

smoketests/tests/domains.py Show resolved Hide resolved
@bfops bfops requested a review from cloutiertyler January 7, 2025 18:20
Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes now look good to me.

@bfops bfops enabled auto-merge January 7, 2025 21:20
@bfops bfops added this pull request to the merge queue Jan 7, 2025
Merged via the queue into master with commit c71b93c Jan 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abi-break A PR that makes an ABI breaking change CLI only This change only affects the CLI behavior release-any To be landed in any release window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants