-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI - dns
subcommand becomes rename
#1694
Conversation
I'm recommending we keep this as a P1 because if we don't then we need the docs to explain what |
Tyler says: we should have a |
Could you add a test for this? Or point to the specific CI test that tests this command? |
https://github.com/clockworklabs/SpacetimeDB/pull/1694/files#diff-c05a1f93f7bbe434d3be3d080b9aff1750af73d7e1fc2870a8a9c9c9550e89e9 has been updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See single comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes now look good to me.
Description of Changes
The
dns
subcommand is half-finished. We are simplifying it for now: it is now justspacetime rename
.API and ABI breaking changes
This removes several
dns
subcommands, and renamesdns set-name
to justrename
.Expected complexity level and risk
2
Testing
Existing CI has been updated (see https://github.com/clockworklabs/SpacetimeDB/pull/1694/files#diff-c05a1f93f7bbe434d3be3d080b9aff1750af73d7e1fc2870a8a9c9c9550e89e9).