Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite C# server modules off V8 to V9 #1948

Closed
RReverser opened this issue Nov 5, 2024 · 2 comments · Fixed by #1670
Closed

Rewrite C# server modules off V8 to V9 #1948

RReverser opened this issue Nov 5, 2024 · 2 comments · Fixed by #1670
Assignees
@RReverser

Comments

@RReverser
Copy link
Member

No description provided.

@RReverser RReverser self-assigned this Nov 5, 2024
@RReverser
Copy link
Member Author

RReverser commented Nov 5, 2024 •
edited
Loading

In-progress PR in #1670. It's currently blocked on final changes in #1918.

@bfops
Copy link
Collaborator

bfops commented Nov 22, 2024

We plan to remove module def v8 by 1.0

RReverser added a commit that referenced this issue Nov 28, 2024
@RReverser
[WIP] C#: migrate from V8 to V9
35d463a 
Migrated C# ModuleDef to V9 as well as adds tests to ensure that identical modules indeed produce identical schemas.

The two remaining discrepancies between Rust and C# are:
 - #1891
 - Row-level security not having a designed API & implementation for C#.

 - Fixes #1948.
 - Fixes #1589.
 - Supersedes #1619.
RReverser added a commit that referenced this issue Nov 28, 2024
@RReverser
[WIP] C#: migrate from V8 to V9
9180254 
Migrated C# ModuleDef to V9 as well as adds tests to ensure that identical modules indeed produce identical schemas.

The two remaining discrepancies between Rust and C# are:
 - #1891
 - Row-level security not having a designed API & implementation for C#.

 - Fixes #1948.
 - Fixes #1589.
 - Supersedes #1619.
RReverser added a commit that referenced this issue Dec 9, 2024
@RReverser
[WIP] C#: migrate from V8 to V9
db75e7e 
Migrated C# ModuleDef to V9 as well as adds tests to ensure that identical modules indeed produce identical schemas.

The two remaining discrepancies between Rust and C# are:
 - #1891
 - Row-level security not having a designed API & implementation for C#.

 - Fixes #1948.
 - Fixes #1589.
 - Supersedes #1619.
@RReverser RReverser mentioned this issue Dec 16, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RReverser RReverser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate C# ModuleDef to V9 clockworklabs/SpacetimeDB
2 participants
@bfops @RReverser