Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: split Iter & IterByColRange types into Tx and MutTxId versions #2024

Open
Centril opened this issue Nov 27, 2024 · 0 comments · May be fixed by #2043
Open

perf: split Iter & IterByColRange types into Tx and MutTxId versions #2024

Centril opened this issue Nov 27, 2024 · 0 comments · May be fixed by #2043
Assignees

Comments

@Centril
Copy link
Contributor

Centril commented Nov 27, 2024

We're wasting work for the Tx version doing unnecessary bookkeeping in case there is a TxState, but there will never be one.
Meanwhile, the MutTxId version is also doing some minor bookkeeping for the case there won't be a TxState, but there always will be one.

In the case of Iter for TxId, this can just be TableScanIter, which is about 4x faster according to flamegraphs.

@Centril Centril self-assigned this Nov 27, 2024
@mamcx mamcx self-assigned this Dec 4, 2024
@mamcx mamcx linked a pull request Dec 9, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants