Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install for callgrind runner docker image #2071

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kazimuth
Copy link
Contributor

Description of Changes

It seems the cargo solver has chosen a crate that doesn't compile with the rustc version in our docker image. This image is only used for benchmarks, so rather than trying to change our iai-callgrind-runner fork, I'm just updating the rustc version in the image.

API and ABI breaking changes

None

Expected complexity level and risk

0

Testing

Going to run the updated actions yml on this branch to see if it works

@kazimuth kazimuth requested a review from RReverser December 18, 2024 21:18
Copy link

github-actions bot commented Dec 18, 2024

Criterion benchmark results

Error when comparing benchmarks: Couldn't find AWS credentials in environment, credentials file, or IAM role.

Caused by:
Couldn't find AWS credentials in environment, credentials file, or IAM role.

Copy link

github-actions bot commented Dec 18, 2024

Callgrind benchmark results Error when comparing benchmarks: Couldn't find AWS credentials in environment, credentials file, or IAM role.

Caused by:
Couldn't find AWS credentials in environment, credentials file, or IAM role.

@kazimuth kazimuth marked this pull request as ready for review December 18, 2024 21:49
@kazimuth
Copy link
Contributor Author

Hmm, the runner is now working. That error is actually an error in the benchmarks comparison application. I'll go poke at that.

@RReverser
Copy link
Member

Maybe now it's down to that regex update that you mentioned will be necessary after C# benchmarks are merged?

Copy link

github-actions bot commented Dec 20, 2024

Criterion benchmark results

Error when comparing benchmarks: Couldn't find AWS credentials in environment, credentials file, or IAM role.

Caused by:
Couldn't find AWS credentials in environment, credentials file, or IAM role.

Copy link

github-actions bot commented Dec 20, 2024

Callgrind benchmark results Error when comparing benchmarks: Couldn't find AWS credentials in environment, credentials file, or IAM role.

Caused by:
Couldn't find AWS credentials in environment, credentials file, or IAM role.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants