Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser should error on unmatched closing paren/brace #25

Closed
ikappaki opened this issue Jun 12, 2020 · 3 comments
Closed

Parser should error on unmatched closing paren/brace #25

ikappaki opened this issue Jun 12, 2020 · 3 comments

Comments

@ikappaki
Copy link
Contributor

e.g. I would have expected the following example with an unmatched closing brace

(require 'parseclj)
(cl-prettyprint (parseclj-parse-clojure "{:a 1}}"))

to give an error such as "At position 7, unmatched :rbrace",

but it returns an emtpy AST

((:node-type . :root)
 (:position . 1)
 (:children ((:node-type) (:position) (:children))))
@plexus
Copy link
Collaborator

plexus commented Sep 27, 2021

Hey, I just copied your snippet and the error you're suggesting is exactly what I'm seeing:

2021-09-27_170647_Emacs

So it would appear this is no longer an issue.

@plexus plexus closed this as completed Sep 27, 2021
@ikappaki
Copy link
Contributor Author

ikappaki commented Sep 27, 2021

(Yes, sorry, I forgot to link it to the #26 PR which fixed it :))

@plexus
Copy link
Collaborator

plexus commented Sep 28, 2021

Ah yes, great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants