Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using *Builders in the native client #95

Open
michaelklishin opened this issue Jul 13, 2014 · 3 comments
Open

Switch to using *Builders in the native client #95

michaelklishin opened this issue Jul 13, 2014 · 3 comments
Assignees

Comments

@michaelklishin
Copy link
Member

ElasticSearch client post 1.0 uses *Builder classes for requests. We should use them where possible (we currently instantiate *Requests directly in most places).

@michaelklishin michaelklishin self-assigned this Jul 13, 2014
@michaelklishin michaelklishin added this to the 4.0 milestone Jun 12, 2016
@jqmtor
Copy link
Contributor

jqmtor commented Sep 24, 2016

Hey @michaelklishin ,

How do you see this change being implemented? The clojurewerkz.elastisch.native.conversion namespace would have a bunch of ->*-builder functions to replace the ->*-request ones?

I've spent some time looking into this but the Elasticsearch docs on the site does not help a lot. I try to see how the previous versions of the Java client worked when compared to the current ones, but sometimes the examples correspond to the current version only (even when I switch to the old ones).

@michaelklishin
Copy link
Member Author

@quimrstorres yup. The conversion functions are not part of the public API, so don't worry about introducing breaking changes. I wouldn't object if this went into 3.0, too.

@jqmtor
Copy link
Contributor

jqmtor commented Sep 25, 2016

@michaelklishin cool, thanks!

@michaelklishin michaelklishin removed this from the 6.0 milestone Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants