benchmaks/scale ends as completed before scaling all the nodes

[morenod]

[2021-10-15 09:14:34,406] {subprocess.py:78} INFO - + sleep 60
[2021-10-15 09:15:34,407] {subprocess.py:78} INFO - + for i in $(seq 1 $_timeout)
[2021-10-15 09:15:34,408] {subprocess.py:78} INFO - ++ oc get nodes --no-headers -l 'node-role.kubernetes.io/worker,node-role.kubernetes.io/master!=,node-role.kubernetes.io/infra!=,node-role.kubernetes.io/workload!=' --ignore-not-found
[2021-10-15 09:15:34,408] {subprocess.py:78} INFO - ++ grep -v NAME
[2021-10-15 09:15:34,408] {subprocess.py:78} INFO - ++ wc -l
[2021-10-15 09:15:34,880] {subprocess.py:78} INFO - + current_workers=18
[2021-10-15 09:15:34,880] {subprocess.py:78} INFO - + echo 'Current worker count: 18'
[2021-10-15 09:15:34,880] {subprocess.py:78} INFO - Current worker count: 18
[2021-10-15 09:15:34,880] {subprocess.py:78} INFO - + echo 'Desired worker count: 3'
[2021-10-15 09:15:34,880] {subprocess.py:78} INFO - Desired worker count: 3
[2021-10-15 09:15:34,880] {subprocess.py:78} INFO - + oc describe -n benchmark-operator benchmarks/scale
[2021-10-15 09:15:34,880] {subprocess.py:78} INFO - + grep State
[2021-10-15 09:15:34,880] {subprocess.py:78} INFO - + grep Complete
[2021-10-15 09:15:35,337] {subprocess.py:78} INFO -   State:           Complete
[2021-10-15 09:15:35,337] {subprocess.py:78} INFO - + '[' 0 -eq 0 ']'
[2021-10-15 09:15:35,337] {subprocess.py:78} INFO - + '[' 18 -eq 3 ']'
[2021-10-15 09:15:35,337] {subprocess.py:78} INFO - + echo 'Scaling completed but desired worker count is not equal to current worker count!'
[2021-10-15 09:15:35,338] {subprocess.py:78} INFO - Scaling completed but desired worker count is not equal to current worker count!
[2021-10-15 09:15:35,338] {subprocess.py:78} INFO - + break
[2021-10-15 09:15:35,338] {subprocess.py:78} INFO - + '[' 1 == 1 ']'
[2021-10-15 09:15:35,338] {subprocess.py:78} INFO - + echo 'Scaling failed'
[2021-10-15 09:15:35,338] {subprocess.py:78} INFO - Scaling failed
[2021-10-15 09:15:35,338] {subprocess.py:78} INFO - + exit 1

[rsevilla87]

If the benchmark is marked as Completed and the number of worker nodes is not the expected the issue could be related with the underlying implementation in benchmark-wrapper and less likely in benchmark-operator.