Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invoke run_benchmark_comparison from utils #395

Open
mohit-sheth opened this issue May 5, 2022 · 2 comments
Open

invoke run_benchmark_comparison from utils #395

mohit-sheth opened this issue May 5, 2022 · 2 comments

Comments

@mohit-sheth
Copy link
Collaborator

Currently run_benchmark_comparison is used by 5 workloads and each have their slightly different implementation of this function. A single function in utils with all the cases covered would reduce duplication of the code
@mohit-sheth
Copy link
Collaborator Author

cc @paigerube14
as discussed in PR #393

@paigerube14 paigerube14 mentioned this issue Jun 23, 2022
Closed
@paigerube14 paigerube14 mentioned this issue Sep 12, 2022
Merged
@paigerube14
Copy link
Collaborator

@mohit-sheth I think we can close this issue as complete?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mohit-sheth @paigerube14