Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests #91

Open
mumoshu opened this issue Mar 14, 2018 · 1 comment
Open

Add unit tests #91

mumoshu opened this issue Mar 14, 2018 · 1 comment

Comments

@mumoshu
Copy link
Collaborator

mumoshu commented Mar 14, 2018

I took a brief look on the current code-base, and noticed that there're no unit tests!

Adding ones would help us better maintain this project in longer term.

Also, I'm happy to contribute here.
Please let me know if there's specific type/func to which you'd like to add tests.

@khash
Copy link
Member

khash commented Apr 5, 2018

I think starting at the build flow level is a good one by adding unit tests around a single step when artifacts are pulled out as well as tests around secret providers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants