Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build images on base image for target platform #1360

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

killianmuldoon
Copy link
Contributor

This change ensure the docker image is built on the same architecture that it's building for. This ensures that other tools in the docker image - e.g. bash - will be usable in the image.

Fixes #1359

@@ -1,4 +1,4 @@
FROM golang:1.20
FROM --platform=${TARGETPLATFORM} golang:1.20
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested that golang images are available for all platforms currently supported - linux/arm64, linux/s390x and linux/amd64

@nickysemenza nickysemenza merged commit 44b96cf into cloudflare:master Mar 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: cfssl/cfssl image builds with wrong base arch
2 participants