bug(d1): too many parameters when preparing a D1 statement

[maurerbot]

just upgraded to wrangler 2.10.0 and getting new D1_ERROR which has the new miniflare version

[cause]: Error: Error: RangeError: Too many parameter values were provided at D1Database._send (node_modules/@miniflare/d1/src/d1js.ts:149:16)

I'm only trying to bind 4 values. Example

db
      .prepare(
        'INSERT INTO node (urn, nid, nss, fragment) VALUES (?1, ?2, ?3, ?4) \
        ON CONFLICT(urn) DO UPDATE SET fragment = excluded.fragment'
      )
      .bind(id, nid, nss, fc)
      .run()

Note this runs fine in CF workers.

[maurerbot]

looks like bind create a new D1PreparedStatement that sets this.params and on the fetch on the binding using _send doesn't like the params.

miniflare/packages/d1/src/d1js.ts

Line 113 in 2d0fbc6

const body = JSON.stringify(

My guess is this is where the error happens? But this is just better-sqlite?

miniflare/packages/d1/src/api.ts

Line 135 in 2d0fbc6

stmt.run(params);

[maurerbot]

using ?, ?, ?, ? instead of ?1, ?2, ?3, ?4 should work. It looks like better-sqlite3 wants params of the form [a,b,c,d] for ?, ?, ?, ? but {1: a, 2: b, 3: c, 4: d} for ?1, ?2, ?3, ?4

Hmmm, looks like there are some open issues/PRs on better-sqlite3 for this:
WiseLibs/better-sqlite3#576
WiseLibs/better-sqlite3#725

[subhendukundu]

Facing the same issue. :(

[michaelcpuckett]

Hi is it possible this issue is not resolved yet?

        const keys = Object.keys(convertedEntity);
        const valuesPlaceholders = keys.map((_, index) => `?${index + 1}`).join(', ');
        const values = Object.values(convertedEntity);
        const stmt = this.db.prepare(`INSERT INTO ${collectionName} (${keys.map(key => `"${key}"`).join(', ')}) VALUES (${valuesPlaceholders});`).bind(...values);
        await stmt.run();