Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

Function to help craft fingerprint fields #21

Open
mholt opened this issue Mar 22, 2020 · 2 comments · May be fixed by #22
Open

Function to help craft fingerprint fields #21

mholt opened this issue Mar 22, 2020 · 2 comments · May be fixed by #22

Comments

@mholt
Copy link

mholt commented Mar 22, 2020 •
edited
Loading

It would be nice if there was a way to populate this structure from a standard *http.Request and *tls.ClientHelloInfo.

In Caddy 1, we were able to get both values in an HTTP request: https://github.com/caddyserver/caddy/blob/891446d06340db2912c9a970bfe862bd54efbb70/caddyhttp/httpserver/mitm.go#L64

However, I am afraid I will fill in the RequestFingerprint struct improperly, it would be super helpful if the lib could do that given the request and ClientHello info.
@lukevalenta
Copy link
Contributor

Thanks for the suggestion! I have a lot of changes planned for this project, so I'll add that to the list.

The timeline for the changes is still unclear, but if this project could be useful for Caddy that's certainly good motivation.

@mholt
Copy link
Author

mholt commented Mar 23, 2020

Cool, yup, that's the plan! I figure/hope this will be better maintained than my spikey implementation of the paper a few years ago. I think if I can bundle in the dataset into the binary, and with that helper function, it should be pretty great to distribute this through a Caddy plugin.

@mholt mholt mentioned this issue Mar 25, 2020
Closed
@jeyrey jeyrey linked a pull request May 26, 2020 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Processor.CheckRequest for webserver integration & demo & tests jeyrey/mitmengine
2 participants
@mholt @lukevalenta