Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy_upstream_filter return value has opposite meaning #386

Open
allan2 opened this issue Sep 16, 2024 · 0 comments
Open

proxy_upstream_filter return value has opposite meaning #386

allan2 opened this issue Sep 16, 2024 · 0 comments
Labels
ergonomics Ease of use, developer friendliness

Comments

@allan2
Copy link
Contributor

allan2 commented Sep 16, 2024

For request_filter , a return value of Ok(false) continues to the next phase.
For proxy_upstream_filter, Ok(true) continues to the next phase.

All of the other methods of ProxyHttp with a Result<bool> signature return Ok(false) by default.

Could proxy_upstream_filter also follow this pattern, returning Ok(false) to continue?

@eaufavor eaufavor added the ergonomics Ease of use, developer friendliness label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ergonomics Ease of use, developer friendliness
Projects
None yet
Development

No branches or pull requests

2 participants