Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this deprecated? #46

Open
naorye opened this issue May 11, 2019 · 9 comments
Open

Is this deprecated? #46

naorye opened this issue May 11, 2019 · 9 comments

Comments

@naorye
Copy link

naorye commented May 11, 2019

No description provided.

@chardskarth
Copy link

I think this library is not actively developed anymore. This is a very nice library and been using it since I first used react.

I've sent an pull request that now uses the new React hooks api. #38 . I've also published it as @chardskarth/react-gateway. Hope you find this useful!

@richardscarrott
Copy link

It'd be a shame if this lib was abandoned as with the support for SSR it's still my goto portal implementation; seems much more powerful than native portals?

@chardskarth
Copy link

Heyy @richardscarrott maybe you could checkout my fork Let me know if it works for you! :D

@nickgraz
Copy link

@chardskarth many blessings on your family, your fork worked beautifully! I have been searching for this solution for a while and I was unable to cook it up myself, thank you so much! Do you have it published as an NPM package? I had to clone it and copy the source into my app.

@chardskarth
Copy link

Hi @nickgraz glad to help! Yeah, this is published. You could do yarn add @chardskarth/react-gateway. Cheers! 🍻

alexnault added a commit to alexnault/awesome-react-components that referenced this issue Feb 2, 2021
Removed react-gateway since last commit dates back November 2017 and React has had built-in Portals for a while now. It looks abandoned (see [this issue](cloudflare/react-gateway#46) and [this issue](cloudflare/react-gateway#32)).
toptaldev92 pushed a commit to toptaldev92/awesome-react-components that referenced this issue Jul 29, 2021
Removed react-gateway since last commit dates back November 2017 and React has had built-in Portals for a while now. It looks abandoned (see [this issue](cloudflare/react-gateway#46) and [this issue](cloudflare/react-gateway#32)).
@richardscarrott
Copy link

Hi @chardskarth does your fork support SSR?

@chardskarth
Copy link

Not sure, haven't tested. 🤔

@richardscarrott
Copy link

richardscarrott commented Nov 11, 2022

@chardskarth that was the primary reason I was using react-gateway over native portals.

From my understanding, I actually don't think SSR portals are viable with React 18 / concurrent mode because all implementations I've seen (including this one) rely on impure instantiation / render fns where they modify context in constructor / componentWillMount / render and, given concurrent mode may call render but never mount a component, it could result in incorrect portal registry state.

@richardscarrott
Copy link

richardscarrott commented Nov 19, 2022

I ended up pushing up a portal implementation we've been using internally that works with React 18 called React Teleportal -- it also doesn't support SSR, but I intend to figure out a concurrent-safe solution soon.

KeepGrowingHere pushed a commit to KeepGrowingHere/awesome-react-components that referenced this issue May 9, 2023
Removed react-gateway since last commit dates back November 2017 and React has had built-in Portals for a while now. It looks abandoned (see [this issue](cloudflare/react-gateway#46) and [this issue](cloudflare/react-gateway#32)).
devsoft0615 added a commit to devsoft0615/React_Component that referenced this issue Jun 20, 2023
Removed react-gateway since last commit dates back November 2017 and React has had built-in Portals for a while now. It looks abandoned (see [this issue](cloudflare/react-gateway#46) and [this issue](cloudflare/react-gateway#32)).
aleksandaralek added a commit to aleksandaralek/awesome-react-components that referenced this issue Oct 24, 2023
Removed react-gateway since last commit dates back November 2017 and React has had built-in Portals for a while now. It looks abandoned (see [this issue](cloudflare/react-gateway#46) and [this issue](cloudflare/react-gateway#32)).
Victory0611 added a commit to Victory0611/awesome-components that referenced this issue Mar 9, 2024
Removed react-gateway since last commit dates back November 2017 and React has had built-in Portals for a while now. It looks abandoned (see [this issue](cloudflare/react-gateway#46) and [this issue](cloudflare/react-gateway#32)).
GoldenPlayBoy added a commit to GoldenPlayBoy/test that referenced this issue Jul 4, 2024
Removed react-gateway since last commit dates back November 2017 and React has had built-in Portals for a while now. It looks abandoned (see [this issue](cloudflare/react-gateway#46) and [this issue](cloudflare/react-gateway#32)).
Watcher919 pushed a commit to Watcher919/react-awesome-components that referenced this issue Aug 25, 2024
Removed react-gateway since last commit dates back November 2017 and React has had built-in Portals for a while now. It looks abandoned (see [this issue](cloudflare/react-gateway#46) and [this issue](cloudflare/react-gateway#32)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants