Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudflare_ruleset resource does not support Cache Reserve Eligibility parameter for Cache Rules #3244

Closed
2 tasks done
jayktaylor opened this issue Apr 15, 2024 · 5 comments · Fixed by #3923
Closed
2 tasks done
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/needs-information Indicates an issue needs more information in order to work on it.
Milestone

Comments

@jayktaylor
Copy link

Confirmation

  • My issue isn't already found on the issue tracker.
  • I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version

Terraform 1.8.0
Provider version 4.29

Affected resource(s)

cloudflare_ruleset

Terraform configuration files

resource "cloudflare_ruleset" "my_ruleset" {
  kind    = "zone"
  name    = "default"
  phase   = "http_request_cache_settings"
  {...}
  rules {
    action = "set_cache_settings"
    action_parameters {
      cache = true
      cache_reserve = false
    }
    description = "Default"
    enabled     = true
    expression  = "(http.host ne \"example.com\")"
  }
}

Link to debug output

N/A

Panic output

No response

Expected output

The resource should be ineligible for Cache Reserve.

Actual output

The resource remained eligible for Cache Reserve, because the parameter is not supported by the Terraform provider. Setting the Cache Reserve Eligibility settings manually using the dashboard or API results in it being wiped out by Terraform on the next terraform apply.

Steps to reproduce

N/A

Additional factoids

No response

References

Support was added upstream in cloudflare/cloudflare-go@3ef5edd but was never added to the Terraform provider.

@jayktaylor jayktaylor added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 15, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

Copy link

Thank you for reporting this issue! For maintainers to dig into issues it is required that all issues include the entirety of TF_LOG=DEBUG output to be provided. The only parts that should be redacted are your user credentials in the X-Auth-Key, X-Auth-Email and Authorization HTTP headers. Details such as zone or account identifiers are not considered sensitive but can be redacted if you are very cautious. This log file provides additional context from Terraform, the provider and the Cloudflare API that helps in debugging issues. Without it, maintainers are very limited in what they can do and may hamper diagnosis efforts.

This issue has been marked with triage/needs-information and is unlikely to receive maintainer attention until the log file is provided making this a complete bug report.

@github-actions github-actions bot added triage/needs-information Indicates an issue needs more information in order to work on it. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 15, 2024
@jacobbednarz
Copy link
Member

as this is a feature request for addition (not a bug), can you please submit this as a regular feature request to Cloudflare Support or your account team through the usual means?

there is some work to automate this in the future but for now, we need to follow the existing product enhancement process.

@jacobbednarz jacobbednarz closed this as not planned Won't fix, can't repro, duplicate, stale Apr 17, 2024
@emilianoangieri
Copy link

is there any feature request opened on this to track, follow or vote?

anthocf added a commit to anthocf/terraform-provider-cloudflare that referenced this issue Sep 9, 2024
anthocf added a commit to anthocf/terraform-provider-cloudflare that referenced this issue Sep 9, 2024
anthocf added a commit to anthocf/terraform-provider-cloudflare that referenced this issue Sep 9, 2024
anthocf added a commit to anthocf/terraform-provider-cloudflare that referenced this issue Sep 10, 2024
@github-actions github-actions bot added this to the v4.42.0 milestone Sep 17, 2024
Copy link

This functionality has been released in v4.42.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2024
grounded042 pushed a commit to grounded042/terraform-provider-cloudflare that referenced this issue Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
3 participants