Updating existing/imported Hyperdrive fails as no ID passed through on Update

[siame]

Confirmation

• My issue isn't already found on the issue tracker.
• I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version

tofu -v
OpenTofu v1.6.0
on darwin_arm64

provider registry.opentofu.org/cloudflare/cloudflare v4.29.0

Affected resource(s)

cloudflare_hyperdrive_config

Terraform configuration files

resource "cloudflare_hyperdrive_config" "hyperdrives" {
  account_id = "my-id"
  name       = "name"
  origin = {
    database = "postgres"
    password = "password"
    host     = "host"
    port     = 5432
    scheme   = "postgres"
    user     = "user"
  }
}

Link to debug output

None

Panic output

No response

Expected output

Should update existing/imported hyperdrive resource with values provided in the cloudflare_hyperdrive_config resource block.

Actual output

╷
│ Error: Error updating hyperdrive config
│
│   with cloudflare_hyperdrive_config.hyperdrives,
│   on cloudflare.tf line 24, in resource "cloudflare_hyperdrive_config" "hyperdrives":
│   24: resource "cloudflare_hyperdrive_config" "hyperdrives" {
│
│ required hyperdrive config id is missing
╵

Steps to reproduce

1. Create hyperdrive outside of terraform
2. Write cloudflare_hyperdrive_config resource block for that above created hyperdrive
3. Import hyperdrive created in step 1 for the resource block created in step 2 using command terraform import cloudflare_hyperdrive_config.example <account_id>/<hyperdrive_config_id>
4. terraform apply to apply changes to reconcile between imported hyperdrive and cloudflare_hyperdrive_config resource
5. Should error

Additional factoids

The error message required hyperdrive config id is missing originates from https://github.com/cloudflare/cloudflare-go/blob/master/hyperdrive.go#L13, which in the context of our update call, starts here: https://github.com/cloudflare/cloudflare-go/blob/master/hyperdrive.go#L176-L178.

This is happening because our call to Update within the terraform-provider does not pass through a HyperdriveID parameter: https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/internal/framework/service/hyperdrive_config/resource.go#L130-L143.

Fixing the provider to pass through HyperdriveID should fix this issue.

References

No response

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[siame]

I'd like to have a go at fixing this issue too.

[github-actions]

Thank you for reporting this issue! For maintainers to dig into issues it is required that all issues include the entirety of TF_LOG=DEBUG output to be provided. The only parts that should be redacted are your user credentials in the X-Auth-Key, X-Auth-Email and Authorization HTTP headers. Details such as zone or account identifiers are not considered sensitive but can be redacted if you are very cautious. This log file provides additional context from Terraform, the provider and the Cloudflare API that helps in debugging issues. Without it, maintainers are very limited in what they can do and may hamper diagnosis efforts.

This issue has been marked with triage/needs-information and is unlikely to receive maintainer attention until the log file is provided making this a complete bug report.

[github-actions]

This functionality has been released in v4.31.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!