New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node:timers/promises does not `signal.removeEventListener('abort')` consistently with the node implementation #3364

Closed

vicb opened this issue Jan 20, 2025 · 0 comments · Fixed by #3380

Assignees

Contributor

vicb commented Jan 20, 2025

The node implementation of node:timers/promises calls signal.removeEventListener('abort')

when the promise returned by setTimeout is settled
when the promise returned by setImmediate is settled

Our current implementation

does never call signal.removeEventListener('abort') for setTimeout
only calls signal.removeEventListener('abort') when the promise rejects (via the AbortSignal) for setImmediate

Should we consider implementing that?

The text was updated successfully, but these errors were encountered:

vicb assigned anonrig

anonrig mentioned this issue

fix node:timers abort callback reset #3380

Merged

anonrig closed this as completed in #3380

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment