Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use correct main file in wrangler.toml for astro + workers assets template #6982

Merged
merged 2 commits into from
Oct 16, 2024
Merged

fix: use correct main file in wrangler.toml for astro + workers assets template #6982

merged 2 commits into from
Oct 16, 2024
+6 −1

Conversation

emily-shen
Copy link
Contributor

@emily-shen emily-shen commented Oct 15, 2024 •
edited
Loading

What this PR solves / how to test

Fixes #6980

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: no relevant tests, tested manually
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no e2e tests for experimental assets templates yet
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix

@emily-shen emily-shen requested review from a team as code owners October 15, 2024 12:48
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 31ee399

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11366178951/npm-package-wrangler-6982

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6982/npm-package-wrangler-6982

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11366178951/npm-package-wrangler-6982 dev path/to/script.js
Additional artifacts: 
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11366178951/npm-package-create-cloudflare-6982 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11366178951/npm-package-cloudflare-kv-asset-handler-6982
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11366178951/npm-package-miniflare-6982
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11366178951/npm-package-cloudflare-pages-shared-6982
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11366178951/npm-package-cloudflare-vitest-pool-workers-6982
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11366178951/npm-package-cloudflare-workers-editor-shared-6982
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11366178951/npm-package-cloudflare-workers-shared-6982

Note that these links will no longer work once the GitHub Actions artifact expires.

[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241011.0
workerd 1.20241011.1 1.20241011.1
workerd --version 1.20241011.1 2024-10-11

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@emily-shen emily-shen merged commit 59c66a4 into main Oct 16, 2024
27 checks passed
@emily-shen emily-shen deleted the emily/fix-astro-template branch October 16, 2024 14:18
@workers-devprod workers-devprod mentioned this pull request Oct 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarmenPopoviciu CarmenPopoviciu CarmenPopoviciu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
workers-sdk
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 BUG: astro + workers assets template is broken with wrangler types
2 participants
@emily-shen @CarmenPopoviciu