Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable & Disable to access public API #83

Open
choonho opened this issue Feb 27, 2024 · 4 comments
Open

Enable & Disable to access public API #83

choonho opened this issue Feb 27, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request security

Comments

@choonho
Copy link
Member

choonho commented Feb 27, 2024

The API like secret.Secret.get_data is quite important. We DONOT want to expose this API to public.

How to disable or enable API for public access.

@choonho choonho added security enhancement New feature or request labels Feb 27, 2024
@choonho
Copy link
Member Author

choonho commented Feb 27, 2024

If we can't enable or disable, it can be configured at ALB.

@ImMin5
Copy link
Member

ImMin5 commented Feb 28, 2024

Hi @choonho

To enable or disable specific APIs, you currently need to modify or delete the corresponding options in our API protos. Since most of our console-api-v2 APIs are auto-generated based on proto files, follow these steps:

  1. Delete the proto option(link)
    image

  2. Build the API

  3. Build console-api-v2

@choonho
Copy link
Member Author

choonho commented Feb 28, 2024

@ImMin5 API proto file is a global library which is shared to everyone. Each customer can not modify their own proto file.
We need other way.

@choonho
Copy link
Member Author

choonho commented Feb 28, 2024

It should be configurable when customer deploys system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request security
Projects
None yet
Development

No branches or pull requests

2 participants