support diffing final releases.

app/fissile.go

@@ -724,14 +724,16 @@ func (f *Fissile) GetDiffConfigurationBases(releasePaths []string, cacheDir stri
 	if len(releasePaths) != 2 {
 		return nil, fmt.Errorf("expected two release paths, got %d", len(releasePaths))
 	}
-	defaultValues := []string{}
-	releases, err := releaseresolver.LoadReleasesFromDisk(model.ReleaseOptions{
-		ReleasePaths:    releasePaths,
-		ReleaseNames:    defaultValues,
-		ReleaseVersions: defaultValues,
-		BOSHCacheDir:    cacheDir})
+	resolver := releaseresolver.NewReleaseResolver(cacheDir)
+	releases, err := resolver.Load(
+		model.ReleaseOptions{
+			ReleasePaths:    releasePaths,
+			ReleaseNames:    []string{},
+			ReleaseVersions: []string{},
+			BOSHCacheDir:    cacheDir},
+		nil)
 	if err != nil {
-		return nil, fmt.Errorf("dev config diff: error loading release information: %s", err)
+		return nil, fmt.Errorf("config diff: error loading release information: %s", err)
 	}
 	return getDiffsFromReleases(releases)
 }

cmd/root.go

@@ -363,6 +363,10 @@ func absolutePaths(paths ...*string) error {
 }
 
 func absolutePath(path string) (string, error) {
+	if strings.Contains(path, "://") {
+		// Special case URLs
+		return path, nil
+	}
 	path, err := filepath.Abs(path)
 	if err != nil {
 		return "", fmt.Errorf("Error getting absolute path for path %s: %v", path, err)

model/loader/loader.go

@@ -4,6 +4,8 @@ package loader
 // resolvers we want to keep `dep ensure` small
 
 import (
+	"path/filepath"
+
 	"code.cloudfoundry.org/fissile/model"
 	"code.cloudfoundry.org/fissile/model/releaseresolver"
 	"code.cloudfoundry.org/fissile/model/resolver"
@@ -17,6 +19,6 @@ func LoadRoleManifest(manifestFilePath string, options model.LoadRoleManifestOpt
 		return nil, err
 	}
 
-	r := releaseresolver.NewReleaseResolver(manifestFilePath)
+	r := releaseresolver.NewReleaseResolver(filepath.Dir(manifestFilePath))
 	return resolver.NewResolver(roleManifest, r, options).Resolve()
 }