Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting the current droplet for an app should not cause pod restart #3234

Open
georgethebeatle opened this issue Apr 25, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@georgethebeatle
Copy link
Member

Reproduction steps

  • Push an app
  • Take record of the cfApp current droplet
  • Change the app code and re-push
  • Wait for the app to start, then set the current droplet of the cfApp to the recorded value
  • The underlying pod will restart

Debugging

When we set the droplet on the app the app controller updates the process with the new build and this build's image propagates all the way down to the spec of the statefulset which (in case the build is different) causes the pod to restart.

This is not how classic CF works. Instead it makes use of the revisions concept so that the user is in control of what is being run and when it is being run.

@georgethebeatle georgethebeatle added the bug Something isn't working label Apr 25, 2024
@github-project-automation github-project-automation bot moved this to 🧊 Icebox in Korifi - Backlog Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🧊 Icebox
Development

No branches or pull requests

1 participant