Bump golang to 1.23 #3395
Comments
danail-branekov
added a commit
to eirini-forks/eirini-station
that referenced
this issue
Jul 18, 2024
golangci-lint does not support go 1.23 yet, therefore we should not be switching to it yet. See cloudfoundry/korifi#3395 This reverts commit 345019c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Although golang 1.23 has not been oficially released yet (ETA August 2024), it has been bumped in the Korifi container images by dependabot and all our tests are fine. Therefore we should probably look into doing that for our code as well.
Unfortunately, staticcheck fails with golang 1.23, see dominikh/go-tools#1578. Once this is resolved with staticcheck, we could go ahead and bump golang (see this wip branch)In order to make staticcheck work, I had to pin it to
2024.1rc1in the Makefile.lateststaticcheck refers to the official release, see dominikh/go-tools#1578 (comment)With that fixed, golangci-lint fails. It seems that it does not support 1.23 and will start supporting it when oficially released.
Once golangci-lint issue is resolved:
The text was updated successfully, but these errors were encountered: