Support synchronous managed service instance creation

[georgethebeatle]

Background

According to the OSBAPI spec the broker may create the service instance synchronously and respond with 201 Created. The spec does not make it clear if getting last operation status will be possible in this case. Some brokers may not be serving the service instance last operation endpoint for synchronous creates, so we should make sure we only get last operation when the broker responeded with 202 Accepted and do nothing otherwise.

Acceptance

GIVEN a managed CFServiceInstance resource is created
WHEN the broker responds with 201 Created to the PUT /v2/service_instances/:instance_id request
THEN the CFServiceInstance becomes ready
AND no GET /v2/service_instances/:instance_id/last_operation request was sent to the OSBAPI broker

Dev Notes

• As the synchronous/asynchronous nature of the OSBAPI request is a low level implementation detail it is not practical to write high level tests (e2e/smoke) for this feature. Instead we should test it with a controller test, where the OSBAPI client is a fake, which makes it easy to check what requests have been performed against the broker