You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the changeView method requires a value for the action argument of either "push" or "pop".
It would be nice if the source order of the views could determine the action to take in cases where that value is not provided. This could be accomplished by comparing the value of @$views.index(@$activeView) with the value of @$views.index($targetView).
This could also allow us to add a new data-attribute, data-changeview, which could do either a push or pop depending on the source order.
The text was updated successfully, but these errors were encountered:
@tylersticka I want to be sure I understand: assuming something like a data-changeview attr, when triggered (click by default), is it that the view indicated (as either the value of the attr or in the href attr) should be pushed if it's later in the DOM and popped if it's earlier? Trying to get my head around this!
@lyzadanger Also, if you'd like, we could use the major version change to change up that syntax.
One thing I've wondered is if it makes more sense to have a separate data-changeview-direction, or to change up the syntax entirely so it's data-slideview-direction: "push" and always either the href or a data-slideview attribute?
Currently, the
changeView
method requires a value for theaction
argument of either"push"
or"pop"
.It would be nice if the source order of the views could determine the action to take in cases where that value is not provided. This could be accomplished by comparing the value of
@$views.index(@$activeView)
with the value of@$views.index($targetView)
.This could also allow us to add a new data-attribute,
data-changeview
, which could do either a push or pop depending on the source order.The text was updated successfully, but these errors were encountered: