Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS linting #497

Closed
2 tasks done
tylersticka opened this issue Feb 24, 2020 · 2 comments
Closed
2 tasks done

CSS linting #497

tylersticka opened this issue Feb 24, 2020 · 2 comments
Assignees
@tylersticka @dromo77
Labels
👷 environment Setup, build tools, configuration, etc.

Comments

@tylersticka
Copy link
Member

tylersticka commented Feb 24, 2020 •
edited
Loading

We should add a Stylelint config to this project.
@tylersticka tylersticka added size:2 👷 environment Setup, build tools, configuration, etc. labels Feb 24, 2020
@spaceninja
Copy link
Member

Note: Our Stylelint config hasn't really been touched since I set up the repo a year ago — let's 100% plug it in, but let's also pay attention to the pain points, so we can update the config to work better for us:

  • As Tyler mentioned, we'll need to update the class naming enforcement from SUIT to BEM-style
  • Are there any rules that you find yourself having to constantly disable? Maybe we should remove them!
  • Are there any rules that you wish we were enforcing? Maybe we should add them!

@tylersticka tylersticka mentioned this issue Feb 24, 2020
Closed
3 tasks
@tylersticka tylersticka self-assigned this Mar 4, 2020
@tylersticka
Copy link
Member Author

I broke the last to-do into its own issue: #517

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tylersticka tylersticka

@dromo77 dromo77

Labels
👷 environment Setup, build tools, configuration, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tylersticka @spaceninja @dromo77