Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset.scss leaks EP-specific styles to the rest of the pattern library #24

Open
Paul-Hebert opened this issue Dec 10, 2019 · 0 comments
Labels
🐛 bug Something isn't working

Comments

@Paul-Hebert
Copy link
Contributor

When building out the Eleventy Patterns scaffolding I wanted some basic reset styles:

* {
  box-sizing: border-box;
  margin: 0;
  padding: 0;
}

I added these in reset.scss but since they target * the styles can end up affecting pattern examples. We'll need to rethink our approach here so that styles written for the scaffolding don't impact the end user's patterns

(Either that or we decide some resets are necessary and put up a disclaimer about it)

@Paul-Hebert Paul-Hebert added the 🐛 bug Something isn't working label Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant