Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An Overview of UI Faults #14

Open
6 tasks
erikjung opened this issue Dec 18, 2015 · 1 comment
Open
6 tasks

An Overview of UI Faults #14

erikjung opened this issue Dec 18, 2015 · 1 comment

Comments

@erikjung
Copy link
Contributor

These lists outline various UI shortcomings (and ideas) pointed out internally over the course of recent project(s) using this pattern library. We should add to these lists when relevant issues concerning this UI are created for projects using it.

Navigation

  • The dark/inverted theme is too distracting. Make it more subtle.
  • The off-canvas is janky (and annoyingly affects scroll position). Use a top-down drawer instead.
  • Consider exposing secondary nav items only when you're on a page from that nav section.

Hierarchy

  • Many items put all variations at the top level, making the code samples too complex. Nest them.
  • Consider copying what Solid does for some section headings: use the CSS classes verbatim.

Misc

  • Code sample lines wrap. They should overflow instead.
@erikjung
Copy link
Contributor Author

@tylersticka @lyzadanger @saralohr @nicolemors Feel free to edit this as needed.

tylersticka added a commit that referenced this issue Dec 28, 2015
Now uses top-down drawer similar to Solid.

Does not yet address IE9 issues related to dependency on classList, but paves the way for that to be a much simpler change.

Refs: #14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant