Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep manual CSV import into a Google Sheets template as an option for next version #144

Open
2 tasks
gerardo-rodriguez opened this issue Jul 19, 2023 · 2 comments

Comments

@gerardo-rodriguez
Copy link
Member

TODO

  • Create a next Google Sheets template
    • connect with @grigs as he may have the most up-to-date Google Sheets to use as the next starter template
  • Add back instructions for how to manually import CSV into Google Sheet template
@calebeby
Copy link
Member

calebeby commented Jul 25, 2023

A challenge with using this approach is that lighthouse-parade@next modifies the spreadsheet based on the data coming out of lighthouse. For example, the number of graphs, the cell coloring (green=low number vs green=high number), and the information below the mean/median on the page with the charts (Lowest scores or Highest values), and skipping making charts for some audits are all are based on the actual data that comes out of the lighthouse reports. The new --lh:only-categories flag controls which categories of audits lighthouse will run, so the columns of the output (and all of those formatting changes that I mentioned) will need to be different based on that flag. If we had a single google sheets template, it would have to be generic enough (by removing those specific formatting choices) to work regardless of the columns that are in the CSV.

Another option might be to save lighthouse reports as JSON to a folder, and allow passing a flag for lighthouse-parade to "slurp up" these JSONs and put them in a spreadsheet, with all the nice formatting stuff that can only happen if we know the actual column types of data that lighthouse is giving us

@gerardo-rodriguez
Copy link
Member Author

Thanks, @calebeby. I like your JSON idea. That might be the better alternative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants