Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring postcss and sass/stylus/css modules via moduleServer options #172

Closed
calebeby opened this issue Jul 20, 2021 · 2 comments

Comments

@calebeby
Copy link
Member

Currently we have a way to configure or disable esbuild via moduleServer options. We should have the same kind of thing for the CSS processing.

It needs to apply the options in the two places where the CSS plugin is used:

Most of the options we will need are the same as: https://github.com/egoist/rollup-plugin-postcss (we do not need all of their options, just a subset).

Here are the things that I think should be possible with the added options (we should have tests for these):

  • Importing CSS modules
  • Enabling postcss plugins
  • Configuring sass/scss options
@calebeby calebeby added feature good first issue Good for newcomers labels Jul 20, 2021
@calebeby
Copy link
Member Author

I realized that rollup-plugin-postcss accounts for over half of pleasantest's dependency graph, and most of the time it isn't even used, except for loading plain CSS without transformations.

graph of Pleasantest's dependencies
graph of rollup-plugin-postcss's dependencies

I would rather make postcss an optional dependency that people can add, rather than including it by default. Because of that, we cannot depend on rollup-plugin-postcss.

I'm marking this as blocked till we find another CSS solution

@calebeby calebeby added blocked and removed good first issue Good for newcomers labels Aug 18, 2021
@calebeby
Copy link
Member Author

calebeby commented Sep 3, 2021

Closing this to be a part of #240

@calebeby calebeby closed this as completed Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant