Merge pull request #2472 from cloudnativedaysjp/fix/stop-later

fix: stop to active job
cloudnativedaysjp · Nov 27, 2024 · f2ceff1 · f2ceff1
2 parents dc91ec5 + 2a4131a
commit f2ceff1
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/app/controllers/api/v1/check_in_conferences_controller.rb b/app/controllers/api/v1/check_in_conferences_controller.rb
@@ -13,7 +13,7 @@ def create
     check_in_timestamp = Time.zone.at(@params[:checkInTimestamp])
     @check_in = CheckInConference.new(profile: attendee, conference:, check_in_timestamp:, scanner_profile_id: @profile.id)
     conference = Conference.find_by(abbr: @params[:eventAbbr])
-    GenerateEntrysheetJob.perform_later(conference.id, attendee.id, speaker&.id, @params[:printerId])
+    GenerateEntrysheetJob.perform_now(conference.id, attendee.id, speaker&.id, @params[:printerId])
 
     if @check_in.save
       render(json: @check_in, status: :created)

diff --git a/app/jobs/generate_entrysheet_job.rb b/app/jobs/generate_entrysheet_job.rb
@@ -44,5 +44,7 @@ def perform(conference_id, profile_id, speaker_id = nil, printer_id = nil)
     response = client.create_printjob(job)
 
     puts("印刷ジョブID: #{response}")
+  ensure
+    File.exist?(pdf_file) && File.delete(pdf_file)
   end
 end
diff --git a/spec/requests/api/v1/check_in_conferences_create_spec.rb b/spec/requests/api/v1/check_in_conferences_create_spec.rb
@@ -16,6 +16,7 @@
     context 'create' do
       before do
         allow(JsonWebToken).to(receive(:verify).and_return(alice_claim))
+        allow(GenerateEntrysheetJob).to(receive(:perform_now))
       end
 
       it 'return ok' do