Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

リード出力のためのrakeタスクを追加 #1712

Closed
wants to merge 3 commits into from
Closed

リード出力のためのrakeタスクを追加 #1712

wants to merge 3 commits into from

Conversation

jacopen
Copy link
Collaborator

@jacopen jacopen commented Dec 16, 2022 •
edited
Loading

リードを出力するためのタスクを追加。
KarteからエクスポートしたAudience CountとProfile SurveyをDBにimportして使う仕組み。

リード出力は各イベントごとに1ショットしかやらない&ひたすらループで出力するのでDBにものすごく負担がかかる･･･ので、Production環境ではは使わず、ダンプしたDBをローカルにimportして出力する想定。なのでAdmin UIの実装は無し

将来的にDkでやるべきかは要相談

@github-actions
Copy link

Review app

@github-actions github-actions bot added the reviewapps Build ReviewApp environment automatically if this label is granted label Dec 16, 2022
@jacopen jacopen removed the reviewapps Build ReviewApp environment automatically if this label is granted label Dec 17, 2022
@github-actions
Copy link

Review app

@github-actions github-actions bot added the reviewapps Build ReviewApp environment automatically if this label is granted label Dec 17, 2022
@jacopen jacopen changed the title WIP リード出力のためのrakeタスクを追加 Dec 17, 2022
@jacopen jacopen marked this pull request as ready for review December 17, 2022 04:12
@takaishi
Copy link
Contributor

やりたいことは理解したが仕組みとしてどうか悩ましい。ちょっと考え中。

KarteからエクスポートしたAudience CountとProfile SurveyをDB

これってどのくらいの量あります？
後、いつまでにリード出力しないといけないのでしたっけか。

@jacopen
Copy link
Collaborator Author

jacopen commented Dec 18, 2022

CNDT2022についてはもうすでにこのrakeタスクを使ってローカルで生成して納品済み。なのでこれを再登板させるのはCICD2023後（3月末）

@jacopen jacopen removed the reviewapps Build ReviewApp environment automatically if this label is granted label Dec 18, 2022
@jacopen
Copy link
Collaborator Author

jacopen commented Dec 18, 2022

@takaishi とのディスカッションの結果、方針としてはこの仕組みをDKに取り込む。ただし、リード出力用であって普段は使わないことをコード的に分かる形にする

となった

@github-actions
Copy link

Review app

@github-actions github-actions bot added the reviewapps Build ReviewApp environment automatically if this label is granted label Mar 23, 2023
@github-actions
Copy link

Simplecov Report

Covered Threshold
61.55% 60%

@jacopen jacopen marked this pull request as draft March 24, 2023 00:11
@jacopen jacopen removed the request for review from takaishi March 24, 2023 00:12
@jacopen jacopen removed the reviewapps Build ReviewApp environment automatically if this label is granted label May 7, 2023
@github-actions
Copy link

github-actions bot commented Sep 3, 2023

Review app

@github-actions github-actions bot added the reviewapps Build ReviewApp environment automatically if this label is granted label Sep 3, 2023
@jacopen jacopen removed the reviewapps Build ReviewApp environment automatically if this label is granted label Sep 3, 2023
@jacopen jacopen closed this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacopen @takaishi