Offair talks having same track id and different conference_day_id #2002
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n start_streaming was called.
github-actions
bot
added
the
reviewapps
Simplecov Report
|
takaishi
reviewed
Aug 11, 2023
app/models/talk.rb
Outdated
| @@ -345,7 +345,7 @@ def start_streaming | |||
| ActiveRecord::Base.transaction do | |||
| other_talks_in_track = conference.tracks.find_by(name: track.name).talks | |||
| .accepted_and_intermission | |||
| .select { |t| t.conference_day.id == conference_day.id && t.id != id } | |||
| .select { |t| t.conference.id == conference.id && t.id != id } | |||
There was a problem hiding this comment.
元々conferenceに紐付くtalkしか取得していないのでconference idの比較は不要な気がする。
Suggested change
| .select { |t| t.conference.id == conference.id && t.id != id } | |
| .select { |t| t.id != id } |
UI側に関しては挙動を変えなくていいので、そこはそのままでいいかなと |
oshiro3
approved these changes
Aug 12, 2023
start_on_airではstart_streamingの実行前に他の日のOnAirをチェックしていて、OnAirならstart_streamingが実行されないのでstart_on_airを直さないといけないと思う。 |
これは期待している挙動通りなので問題ないような？ |
|
あ、APIの時の挙動についての変更か。勘違いしていた。 |
takaishi
approved these changes
Aug 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2001
2001の修正方法として
の2つのアプローチがあるが、UIは前者のアプローチでバリデーションしている。これはUIの構成上誤操作のリスクがあるので好ましい動作。
しかしAPIの利用シーン的には後者のほうが便利だし、誤操作のリスクはそれほど高くない(talk_idを明示するので曜日を誤指定することは考えづらい)
そのため、フィルタリング条件を変更して別日であっても自動的にオフになるようにした