Simplify ticket system #2014
Merged
Simplify ticket system #2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
reviewapps
takaishi
requested changes
Sep 6, 2023
takaishi
reviewed
Sep 6, 2023
app/views/profiles/_form.html.erb
Outdated
| <div class="col-12 col-md-6" id="participation" > | ||
| <%= form.label :participation, "参加方法" %></br> | ||
| <%= form.radio_button :participation, :online, { class: "radio_button_participation", id: "participation_online" } %> | ||
| <%= form.label :online, { for: "participation_online" } %> |
takaishi
reviewed
Sep 6, 2023
| @@ -0,0 +1,5 @@ | |||
| class AddParticipationColumnsToProfile < ActiveRecord::Migration[7.0] | |||
| def change | |||
| add_column :profiles, :participation, :string | |||
There was a problem hiding this comment.
現地参加可能な人数は上限があるので、それを管理できるようにしてもらえますか？
チケットの時はticketsテーブルに管理用のカラムがありました。
There was a problem hiding this comment.
定員を Conference に持たせて管理するようにしました。
Simplecov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
思ったより変更範囲が多くなってしまった感じですがチケットで処理していた部分を Profile の Enum で置き換えるように変更しました。