Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CNDS2025 #2484

Merged
merged 4 commits into from
Feb 19, 2025
Merged

Add CNDS2025 #2484

merged 4 commits into from
Feb 19, 2025

Conversation

jacopen
Copy link
Collaborator

@jacopen jacopen commented Feb 18, 2025

No description provided.

@gitops-for-cloudnativedays gitops-for-cloudnativedays bot added the reviewapps Build ReviewApp environment automatically if this label is granted label Feb 18, 2025
gitops-for-cloudnativedays bot pushed a commit to cloudnativedaysjp/dreamkast-infra that referenced this pull request Feb 18, 2025
Copy link

gitops-for-cloudnativedays bot added a commit to cloudnativedaysjp/dreamkast-infra that referenced this pull request Feb 18, 2025
Copy link

Simplecov Report

Covered Threshold
61.8% 60%

@jacopen jacopen requested a review from Copilot February 18, 2025 14:36
gitops-for-cloudnativedays bot pushed a commit to cloudnativedaysjp/dreamkast-infra that referenced this pull request Feb 18, 2025
gitops-for-cloudnativedays bot added a commit to cloudnativedaysjp/dreamkast-infra that referenced this pull request Feb 18, 2025
@jacopen jacopen requested a review from a team February 18, 2025 14:36

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 14 out of 22 changed files in this pull request and generated no comments.

Files not reviewed (8)
  • app/javascript/stylesheets/cnds2025.scss: Language not supported
  • app/javascript/stylesheets/cnds2025/_cnds2025.scss: Language not supported
  • app/javascript/stylesheets/cnds2025/_timetable.scss: Language not supported
  • app/javascript/stylesheets/cnds2025/_utilities.scss: Language not supported
  • app/javascript/stylesheets/cnds2025/_variables.scss: Language not supported
  • app/views/event/cnds2025_show.html.erb: Evaluated as low risk
  • app/views/speaker_dashboard/speakers/_guidance_section_1.html.erb: Evaluated as low risk
  • app/views/speaker_dashboard/speakers/_guidance_section_2.html.erb: Evaluated as low risk
</div>
<div class="col-lg-12 text-center mt-4 projects" id="project-list">
<h2 class="text-black mt-0">企画一覧</h2>
<%= render(partial: "contents/cndw2024/projects") %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CNDWのURLとロゴが見えてる

Uploading image.png…

gitops-for-cloudnativedays bot pushed a commit to cloudnativedaysjp/dreamkast-infra that referenced this pull request Feb 19, 2025
gitops-for-cloudnativedays bot added a commit to cloudnativedaysjp/dreamkast-infra that referenced this pull request Feb 19, 2025
EOS
},
{
id: 13,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

01_proposal_item_configs.rb などの追加も必要でした!

gitops-for-cloudnativedays bot pushed a commit to cloudnativedaysjp/dreamkast-infra that referenced this pull request Feb 19, 2025
gitops-for-cloudnativedays bot added a commit to cloudnativedaysjp/dreamkast-infra that referenced this pull request Feb 19, 2025
@jacopen jacopen requested review from takaishi and Copilot February 19, 2025 02:54
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 14 out of 24 changed files in this pull request and generated 2 comments.

Files not reviewed (10)
  • app/javascript/stylesheets/cnds2025.scss: Language not supported
  • app/javascript/stylesheets/cnds2025/_cnds2025.scss: Language not supported
  • app/javascript/stylesheets/cnds2025/_timetable.scss: Language not supported
  • app/javascript/stylesheets/cnds2025/_utilities.scss: Language not supported
  • app/javascript/stylesheets/cnds2025/_variables.scss: Language not supported
  • app/views/event/cnds2025_show.html.erb: Evaluated as low risk
  • app/views/speaker_dashboard/speakers/_guidance_section_1.html.erb: Evaluated as low risk
  • app/views/speaker_dashboard/speakers/_guidance_section_2.html.erb: Evaluated as low risk
  • app/views/speaker_dashboard/speakers/guidance.html.erb: Evaluated as low risk
  • webpack.config.js: Evaluated as low risk

推しのプロダクトをとことん使い込んでいたり、OSSの開発に熱中するエンジニアたちが集まり、
その知見や思いを共有し合うことで新たな発想や出会いが生まれていくのです。

2025年は、日本でCloudNativeがいっそう盛り上がる、まさに"情熱"に満ちた年となるでしょう。
Copy link
Preview

Copilot AI Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word 'いっそう' should be '一層' to maintain consistency and correctness in the Japanese text.

Suggested change
2025年は、日本でCloudNativeがいっそう盛り上がる、まさに"情熱"に満ちた年となるでしょう。
2025年は、日本でCloudNativeが一層盛り上がる、まさに"情熱"に満ちた年となるでしょう。

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
items: [
{
id: 195,
key: SessionTime::FOURTY_MINUTES,
Copy link
Preview

Copilot AI Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word 'FOURTY' is misspelled. It should be 'FORTY'.

Suggested change
key: SessionTime::FOURTY_MINUTES,
key: SessionTime::FORTY_MINUTES,

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Copy link
Contributor

@takaishi takaishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!!!!!!!!!

@jacopen jacopen merged commit 24a6abe into main Feb 19, 2025
6 checks passed
@jacopen jacopen deleted the cnds2025-seed branch February 19, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewapps Build ReviewApp environment automatically if this label is granted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants