New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dkWatcher から notifier への通知の回数を抑制する #19

Closed

ShotaKitazawa opened this issue Sep 25, 2022 · 1 comment

Assignees

Milestone

Member

ShotaKitazawa commented Sep 25, 2022

現状、「現在のトーク終了まで残り5分を切ったら30秒ごとに通知」という実装になってしまっている
これを、「現在のトーク終了まで残り5分を切ったら 1 度だけ通知」という実装に直す
https://github.com/cloudnativedaysjp/cnd-operation-server/blob/f4f29524f61abdddcd9269763ffcb0a2bc59845c/pkg/dkwatcher/dkwatcher.go#L95-L97

Member Author

ShotaKitazawa commented Sep 25, 2022

#13 もあるので redis を使うのが丸そう

ShotaKitazawa added this to the v1.0.0 milestone

ShotaKitazawa assigned tkc66-buzz

tkc66-buzz added a commit that referenced this issue


          Merge branch 'main' into issue/#19

324ec72

tkc66-buzz mentioned this issue

Merged

tkc66-buzz added a commit that referenced this issue


          Merge remote-tracking branch 'origin/issue/#19_kanata' into issue/#19

67c2612

ShotaKitazawa added a commit that referenced this issue


          Merge pull request #50 from cloudnativedaysjp/issue/#19

a74df16

Issue/#19

tkc66-buzz closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment