Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add archives for CNDS2023 and upcoming events (CNDW2024) #256

Merged
merged 3 commits into from
Sep 29, 2024
Merged

Conversation

takaishi
Copy link
Contributor

No description provided.

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-256.d1fbfmeuaycsih.amplifyapp.com

"trackId": 49,
"videoPlatform": null,
"videoId": "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[確認]
こちらのセッションはビデオ公開不可でしたっけ?

[メモ]
videoIdがない場合、ビデオが表示されるはずの部分になにも表示されず実装漏れのように見えてしまう。
公開不可の文言を表示するなどのケアをしておいたほうがよさそう。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

公開可能なのですが、アーカイブ動画のURLがDk上に保存されていないですね。

@jacopen jacopen merged commit 7401eb5 into main Sep 29, 2024
1 check passed
@jacopen jacopen deleted the cndw2024 branch September 29, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants