Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFAC] - Standardise and combine HelmController, WorkloadStatusController, HelmChartTestController #585

Open
2 tasks
Tracked by #726
IvoGoman opened this issue Sep 17, 2024 · 0 comments · May be fixed by #861
Open
2 tasks
Tracked by #726

[REFAC] - Standardise and combine HelmController, WorkloadStatusController, HelmChartTestController #585

IvoGoman opened this issue Sep 17, 2024 · 0 comments · May be fixed by #861
Assignees
@Zaggy21

Comments

@IvoGoman
Copy link
Contributor

IvoGoman commented Sep 17, 2024 •
edited
Loading

Priority

medium

Description

As part of #544 all controllers within Greenhouse should implement the Reconciler interface.

Combining the HelmController, WorkloadStatusController and HelmChartTestController brings some challenges.
The WorkloadStatusController is periodically running, but the HelmController should not diff the release if nothing changed.

The proposal is to store the checksum of the current Plugin .spec.optionValues in the Plugin status next to the status.helmReleaseStatus.pluginOptionChecksum.
This will enable skipping a helm diff in case 1. Helm Chart Version has not changed, 2. Checksum is the same, 3. not in the current drift detection interval

Acceptance Criteria

  • The HelmController, WorkloadStatusController and HelmChartTestController are combined into a PluginController
  • There is a new status condition on the Plugin that stores a checksum of the current configuration

Reference Issues

No response
@IvoGoman IvoGoman mentioned this issue Sep 17, 2024
Closed
9 tasks
@github-project-automation github-project-automation bot moved this to Sprint Backlog in Greenhouse Core Roadmap Sep 17, 2024
@IvoGoman IvoGoman changed the title [FEAT] - Standardise and combine HelmController, WorkloadStatusController, HelmChartTestController [REFAC] - Standardise and combine HelmController, WorkloadStatusController, HelmChartTestController Sep 17, 2024
@viennaa viennaa mentioned this issue Sep 24, 2024
Closed
This was referenced Dec 11, 2024
Open
Open
@Zaggy21 Zaggy21 self-assigned this Jan 7, 2025
@Zaggy21 Zaggy21 moved this from Sprint Backlog to Todo in Greenhouse Core Roadmap Jan 7, 2025
@Zaggy21 Zaggy21 moved this from Todo to In progress in Greenhouse Core Roadmap Jan 8, 2025
@Zaggy21 Zaggy21 linked a pull request Jan 23, 2025 that will close this issue
Open
24 tasks
@Zaggy21 Zaggy21 linked a pull request Jan 23, 2025 that will close this issue
refactor(plugins): standardize and combine plugin controllers #861
Open
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zaggy21 Zaggy21

Labels
None yet
Projects
Greenhouse Core Roadmap
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(plugins): standardize and combine plugin controllers cloudoperators/greenhouse
2 participants
@IvoGoman @Zaggy21