Implement: atmos list values

.golangci.yml

@@ -16,7 +16,6 @@ linters:
     - gocognit # Check cognitive complexity
     - gocritic # Enable additional checks for code issues
     - godot # Enforce comment formatting
-    - gofmt # Enforce gofmt style
     - gofumpt # Enforce consistent formatting
     - goimports # Enforce import formatting
     - gosec # Inspect source code for security problems
@@ -51,14 +50,6 @@ linters-settings:
     excludes:
       - G101 # Look for hard coded credentials
 
-  gofmt:
-    # Simplify code: gofmt -s
-    simplify: true
-    # Define indentation
-    rewrite-rules:
-      - pattern: "interface{}"
-        replacement: "any"
-
   cyclop:
     # Maximum function complexity
     max-complexity: 15
@@ -104,7 +95,7 @@ linters-settings:
       - name: add-constant
         arguments:
           - maxLitCount: "3"
-            allowStrs: '""'
+            allowStrs: '"","error"'
             allowInts: "0,1,2,3,4"
             allowFloats: "0.0,0.,1.0,1.,2.0,2."
       - name: argument-limit
@@ -169,6 +160,7 @@ issues:
         - funlen
         - revive
         - gci
+        - gocognit
 
 output:
   formats:

cmd/cmd_utils.go

@@ -46,12 +46,6 @@ func processCustomCommands(
 	var command *cobra.Command
 	existingTopLevelCommands := make(map[string]*cobra.Command)
 
-	// Build commands and their hierarchy from the alias map
-	for alias, fullCmd := range atmosConfig.CommandAliases {
-		parts := strings.Fields(fullCmd)
-		addCommandWithAlias(RootCmd, alias, parts)
-	}
-
 	if topLevel {
 		existingTopLevelCommands = getTopLevelCommands()
 	}

cmd/list.go

@@ -4,11 +4,12 @@ import (
 	"github.com/spf13/cobra"
 )
 
-// listCmd commands list stacks and components
+// listCmd represents the base list command that provides subcommands for listing
+// various Atmos resources like stacks, components, settings, metadata, etc.
 var listCmd = &cobra.Command{
-	Use:                "list",
-	Short:              "List available stacks and components",
-	Long:               `Display a list of all available stacks and components defined in your project.`,
+	Use:                "list [command]",
+	Short:              "List Atmos resources and configurations",
+	Long:               "List and display Atmos resources and configurations",
 	FParseErrWhitelist: struct{ UnknownFlags bool }{UnknownFlags: false},
 	Args:               cobra.NoArgs,
 }

cmd/list_metadata.go

@@ -0,0 +1,97 @@
+package cmd
+
+import (
+	log "github.com/charmbracelet/log"
+	"github.com/spf13/cobra"
+
+	e "github.com/cloudposse/atmos/internal/exec"
+	"github.com/cloudposse/atmos/pkg/config"
+	l "github.com/cloudposse/atmos/pkg/list"
+	"github.com/cloudposse/atmos/pkg/list/errors"
+	fl "github.com/cloudposse/atmos/pkg/list/flags"
+	f "github.com/cloudposse/atmos/pkg/list/format"
+	u "github.com/cloudposse/atmos/pkg/list/utils"
+	"github.com/cloudposse/atmos/pkg/schema"
+	utils "github.com/cloudposse/atmos/pkg/utils"
+)
+
+// listMetadataCmd lists metadata across stacks.
+var listMetadataCmd = &cobra.Command{
+	Use:   "metadata",
+	Short: "List metadata across stacks",
+	Long:  "List metadata information across all stacks",
+	Example: "atmos list metadata\n" +
+		"atmos list metadata --query .component\n" +
+		"atmos list metadata --format json\n" +
+		"atmos list metadata --stack '*-{dev,staging}-*'\n" +
+		"atmos list metadata --stack 'prod-*'",
+	Run: func(cmd *cobra.Command, args []string) {
+		// Check Atmos configuration
+		checkAtmosConfig()
+		output, err := listMetadata(cmd)
+		if err != nil {
+			log.Error("failed to list metadata", "error", err)
+			return
+		}
+
+		utils.PrintMessage(output)
+	},
+}
+
+func init() {
+	fl.AddCommonListFlags(listMetadataCmd)
+
+	AddStackCompletion(listMetadataCmd)
+
+	listCmd.AddCommand(listMetadataCmd)
+}
+
+func listMetadata(cmd *cobra.Command) (string, error) {
+	commonFlags, err := fl.GetCommonListFlags(cmd)
+	if err != nil {
+		return "", &errors.QueryError{
+			Query: "common flags",
+			Cause: err,
+		}
+	}
+
+	if f.Format(commonFlags.Format) == f.FormatCSV && commonFlags.Delimiter == f.DefaultTSVDelimiter {
+		commonFlags.Delimiter = f.DefaultCSVDelimiter
+	}
+
+	// Initialize CLI config
+	configAndStacksInfo := schema.ConfigAndStacksInfo{}
+	atmosConfig, err := config.InitCliConfig(configAndStacksInfo, true)
+	if err != nil {
+		return "", &errors.InitConfigError{Cause: err}
+	}
+
+	// Get all stacks
+	stacksMap, err := e.ExecuteDescribeStacks(atmosConfig, "", nil, nil, nil, false, false, false, false, nil)
+	if err != nil {
+		return "", &errors.DescribeStacksError{Cause: err}
+	}
+
+	// Use .metadata as the default query if none provided
+	if commonFlags.Query == "" {
+		commonFlags.Query = ".metadata"
+	}
+
+	output, err := l.FilterAndListValues(stacksMap, &l.FilterOptions{
+		Component:       "",
+		Query:           commonFlags.Query,
+		IncludeAbstract: false,
+		MaxColumns:      commonFlags.MaxColumns,
+		FormatStr:       commonFlags.Format,
+		Delimiter:       commonFlags.Delimiter,
+		StackPattern:    commonFlags.Stack,
+	})
+	if err != nil {
+		if u.IsNoValuesFoundError(err) {
+			return "", &errors.NoMetadataFoundError{Query: commonFlags.Query}
+		}
+		return "", &errors.MetadataFilteringError{Cause: err}
+	}
+
+	return output, nil
+}

cmd/list_settings.go

@@ -0,0 +1,91 @@
+package cmd
+
+import (
+	log "github.com/charmbracelet/log"
+	"github.com/spf13/cobra"
+
+	e "github.com/cloudposse/atmos/internal/exec"
+	"github.com/cloudposse/atmos/pkg/config"
+	l "github.com/cloudposse/atmos/pkg/list"
+	"github.com/cloudposse/atmos/pkg/list/errors"
+	fl "github.com/cloudposse/atmos/pkg/list/flags"
+	f "github.com/cloudposse/atmos/pkg/list/format"
+	u "github.com/cloudposse/atmos/pkg/list/utils"
+	"github.com/cloudposse/atmos/pkg/schema"
+	utils "github.com/cloudposse/atmos/pkg/utils"
+)
+
+// listSettingsCmd lists settings across stacks.
+var listSettingsCmd = &cobra.Command{
+	Use:   "settings",
+	Short: "List settings across stacks",
+	Long:  "List settings configuration across all stacks",
+	Example: "atmos list settings\n" +
+		"atmos list settings --query .terraform\n" +
+		"atmos list settings --format json\n" +
+		"atmos list settings --stack '*-dev-*'\n" +
+		"atmos list settings --stack 'prod-*'",
+	Run: func(cmd *cobra.Command, args []string) {
+		// Check Atmos configuration
+		checkAtmosConfig()
+		output, err := listSettings(cmd)
+		if err != nil {
+			log.Error("failed to list settings", "error", err)
+			return
+		}
+
+		utils.PrintMessage(output)
+	},
+}
+
+func init() {
+	fl.AddCommonListFlags(listSettingsCmd)
+
+	AddStackCompletion(listSettingsCmd)
+
+	listCmd.AddCommand(listSettingsCmd)
+}
+
+func listSettings(cmd *cobra.Command) (string, error) {
+	// Get common flags
+	commonFlags, err := fl.GetCommonListFlags(cmd)
+	if err != nil {
+		return "", &errors.CommonFlagsError{Cause: err}
+	}
+
+	if f.Format(commonFlags.Format) == f.FormatCSV && commonFlags.Delimiter == f.DefaultTSVDelimiter {
+		commonFlags.Delimiter = f.DefaultCSVDelimiter
+	}
+
+	// Initialize CLI config
+	configAndStacksInfo := schema.ConfigAndStacksInfo{}
+	atmosConfig, err := config.InitCliConfig(configAndStacksInfo, true)
+	if err != nil {
+		return "", &errors.InitConfigError{Cause: err}
+	}
+
+	// Get all stacks
+	stacksMap, err := e.ExecuteDescribeStacks(atmosConfig, "", nil, nil, nil, false, false, false, false, nil)
+	if err != nil {
+		return "", &errors.DescribeStacksError{Cause: err}
+	}
+
+	// Use empty query to avoid further processing since handleComponentProperties will extract the settings
+	output, err := l.FilterAndListValues(stacksMap, &l.FilterOptions{
+		Component:       "settings",
+		Query:           commonFlags.Query,
+		IncludeAbstract: false,
+		MaxColumns:      commonFlags.MaxColumns,
+		FormatStr:       commonFlags.Format,
+		Delimiter:       commonFlags.Delimiter,
+		StackPattern:    commonFlags.Stack,
+	})
+	if err != nil {
+		if u.IsNoValuesFoundError(err) {
+			return "", &errors.NoSettingsFoundError{Query: commonFlags.Query}
+		}
+		return "", &errors.SettingsFilteringError{Cause: err}
+	}
+
+	return output, nil
+}

cmd/list_stacks.go

@@ -1,17 +1,16 @@
 package cmd
 
 import (
-	"fmt"
 	"strings"
 
+	log "github.com/charmbracelet/log"
 	"github.com/spf13/cobra"
 
 	e "github.com/cloudposse/atmos/internal/exec"
 	"github.com/cloudposse/atmos/pkg/config"
 	l "github.com/cloudposse/atmos/pkg/list"
 	"github.com/cloudposse/atmos/pkg/schema"
-	"github.com/cloudposse/atmos/pkg/ui/theme"
-	u "github.com/cloudposse/atmos/pkg/utils"
+	"github.com/cloudposse/atmos/pkg/utils"
 )
 
 // listStacksCmd lists atmos stacks
@@ -28,10 +27,10 @@ var listStacksCmd = &cobra.Command{
 		checkAtmosConfig()
 		output, err := listStacks(cmd)
 		if err != nil {
-			u.PrintErrorMarkdownAndExit("Error filtering stacks", err, "")
+			log.Error("error filtering stacks", "error", err)
 			return
 		}
-		u.PrintMessageInColor(strings.Join(output, "\n")+"\n", theme.Colors.Success)
+		utils.PrintMessage(strings.Join(output, "\n"))
 	},
 }
 
@@ -46,11 +45,13 @@ func listStacks(cmd *cobra.Command) ([]string, error) {
 	configAndStacksInfo := schema.ConfigAndStacksInfo{}
 	atmosConfig, err := config.InitCliConfig(configAndStacksInfo, true)
 	if err != nil {
-		return nil, fmt.Errorf("Error initializing CLI config: %v", err)
+		log.Error("failed to initialize CLI config", "error", err)
+		return nil, err
 	}
 	stacksMap, err := e.ExecuteDescribeStacks(atmosConfig, "", nil, nil, nil, false, false, false, false, nil)
 	if err != nil {
-		return nil, fmt.Errorf("Error describing stacks: %v", err)
+		log.Error("failed to describe stacks", "error", err)
+		return nil, err
 	}
 
 	output, err := l.FilterAndListStacks(stacksMap, componentFlag)