fix: private api gateways with vpce need policy #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Cloud Posse Engineering Team Review RequiredThis pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes. To expedite this process, reach out to us on Slack in the |
|
/terratest |
dudymas
force-pushed
the
fix/vpce/add-resource-policy
branch
from
9a47044
to
62c1840
Compare
osterman
reviewed
Oct 18, 2024
osterman
reviewed
Oct 18, 2024
main.tf
Outdated
Comment on lines
26
to
53
| policy = var.rest_api_policy | ||
| policy = data.aws_iam_policy_document.default[0].json |
There was a problem hiding this comment.
We should preserve the current functionality, no?
There was a problem hiding this comment.
the source policy is input here:
terraform-aws-api-gateway/main.tf
Line 25 in af83cc3
There was a problem hiding this comment.
osterman
reviewed
Oct 18, 2024
| rest_api_id = aws_api_gateway_rest_api.this[0].id | ||
|
|
||
| policy = var.rest_api_policy | ||
| policy = data.aws_iam_policy_document.this[0].json |
There was a problem hiding this comment.
There was a problem hiding this comment.
...so the user can pass additional policies preserving the current functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
permission to use that endpoint
references