- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update portMappings to include containerPortRange #178
Conversation
variables.tf
Outdated
protocol = optional(string) | ||
name = optional(string) | ||
appProtocol = optional(string) | ||
containerPortRange = optional(string) | ||
})) | ||
description = "The port mappings to configure for the container. This is a list of maps. Each map should contain \"containerPort\", \"hostPort\", and \"protocol\", where \"protocol\" is one of \"tcp\" or \"udp\". If using containers in a task with the awsvpc or host network mode, the hostPort can either be left blank or set to the same value as the containerPort" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to include containerPortRange
in the description if possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just indicated that it's an alternative to containerPort, hope that's okay?
/terratest |
/terratest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @asmithdt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asmithdt can you please address this error in the terratest and update it?
https://github.com/cloudposse/actions/actions/runs/7712166124/job/21019086777
Hi @asmithdt |
Apologies, I missed these messages. I have made a change which I hope will resolve the tests, I can't seem to run locally to check though; not sure if that's something I need to setup with the build-harness? Let me know if that doesn't get it. Cheers! |
💥 This pull request now has conflicts. Could you fix it @asmithdt? 🙏 |
This PR was closed due to inactivity and merge conflicts. 😭 |
@asmithdt Anything I can do to help on this? Honestly not sure how to get |
💥 This pull request now has conflicts. Could you fix it @asmithdt? 🙏 |
Hi @asmithdt Sorry for the delay. Could you please run the following and commit the result?
|
This PR was closed due to inactivity and merge conflicts. 😭 |
what
Allow specifying containerPortRange in portMappings
why
To support containerPortRange
references