feat: ✨ added restart policies #192
Conversation
|
|
||
| variable "restart_policy" { | ||
| type = object({ | ||
| enabled = optional(bool) |
There was a problem hiding this comment.
Will this variable be valid if something is supplied, but enabled is left out? Maybe this should be the one required argument to this var?
There was a problem hiding this comment.
Yeah, I'm not sure - I just went off what the AWS Console generated haha
I can make this one non-optional if that is preferred?
Seems |
|
@JaydenMaalouf I wonder if you have a bad version of |
Turns out the issue was running it on a Windows shell. Switched to WSL and reran make. Seemed to work! |
|
@JaydenMaalouf could you pls add a description to this input I know that's not a part of the PR changes, but unfortunately, we test all terraform files and have such side effects. |
|
💥 This pull request now has conflicts. Could you fix it @JaydenMaalouf? 🙏 |
|
Is there anything that can be done to expedite this PR? It seems like it's already complete, but happy to contribute. |
Gowiem
added
minor
|
/terratest |
|
Hey @JaydenMaalouf any chance you could run Apologies for pinging directly - just very interested in having this feature available :) |
|
Folks, can we please have this merged? |
|
@tovbinm not until tests are passing |
what
Adds container restart policies to the container definition
why
This feature was introduced by AWS recently but has not made its way to this container
references