Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow skip saving ssh keys to files #86

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: allow skip saving ssh keys to files #86

wants to merge 1 commit into from

Conversation

aslafy-z
Copy link

@aslafy-z aslafy-z commented Jul 4, 2024 •
edited
Loading

what

  • Make optional the saving of ssh keys to disk with the var.write_ssh_key boolean

why

  • The keys are ephemeral and I don't want them to go to the disk, only in the terraform state

references

closes #64

@mergify mergify bot added the triage Needs triage label Jul 4, 2024
@aslafy-z aslafy-z marked this pull request as ready for review July 4, 2024 09:52
@aslafy-z aslafy-z requested review from a team as code owners July 4, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johncblandii johncblandii Awaiting requested review from johncblandii johncblandii is a code owner automatically assigned from cloudposse/contributors

@nitrocode nitrocode Awaiting requested review from nitrocode nitrocode is a code owner automatically assigned from cloudposse/contributors

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
triage Needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to not save key
1 participant
@aslafy-z