Output instance endpoints, add attributes to random_pet that force a new instance

[finchr]

…new instance

what

• output instance endpoints
• add aws_rds_cluster_instance attributes that force a new instance to the randmon_pet resource. (Reverted in Multiple cleanups #242 due to 1.13.0 is forcing a recreate of the cluster instance  #241)

why

• I need the actual instance endpoints for the Datadog DMS integration, the default dashboards work better with the exact instance identifier.
• Currently if any of these attributes change (db_subnet_group_name, engine) it will bypass the random_pet and attempt to create instances with the same identifier.

references

[aknysh]

/terratest

[aknysh]

thanks @finchr

[github-actions]

These changes were released in v1.13.0.

[mihaiplesa]

Is this not a breaking change with potential of data loss, especially for clusters of size 1? In that case it should be described as backwards incompatible and have a conditional flag to prevent recreation/destroy of existing resources.

[finchr]

Is this not a breaking change with potential of data loss, especially for clusters of size 1? In that case it should be described as backwards incompatible and have a conditional flag to prevent recreation/destroy of existing resources.

Hi @mihaiplesa this is not a breaking change, it just covers a few missed attributes from a previous PR which might have caused problems if certain attributes were changed and also adds the instance endpoints to the output.

[oycyc]

this forces a replacement even though the actual value of the identifier hasn't changed, but because the attribute changed (the source of the attribute), it's forcing a replacement 😬

[oycyc]

this is forcing a replacement in the resource "aws_rds_cluster_instance" "default" { now that these attribute values are changing (even if the end result value is the same). this would cause a recreate of the database instance... see example plan above

[GabisCampana]

@aknysh