🚀 Enhancements
- Implement and close #237 (add option for local write forwarding) Thank you @Junaid-Tem
- Implement and close #239 (allow the configuration of
reservation_idforaws_rds_reserved_instance) Thank you @oycyc
🐛 Bug Fixes
Multiple cleanups @Nuru (#242)
## what- Partly revert #236 (see discussion below)
- Allow explicitly naming parameter group
- Use full name of engine for reserved DB instances
- Implement and close #197
- Implement and close #199
- Implement and close #230 Thank you @raymondchen625
why
discussion: why partially revert #236?
PR #236 enhanced the random_pet that determines part of the name of the DB instances so that the name would change whenever the instances would need to be recreated. Unfortunately, as a side-effect, that causes all instances created with earlier versions of this module to be replaced.
Upon further investigation, it was determined that all the "keepers" added by the PR would also force the cluster to be replaced. Unlike replacing an instance, replacing the cluster results in data loss. Also, unless you change the name of the cluster, the module both before and after the PR would fail, because it would try to create a new cluster with the same name before destroying the old cluster.
We prefer this failure mode, requiring the user to explicitly destroy the cluster before creating the new one, because it puts the user on notice about the potential data loss. So given that the changes in the PR did not make something work that did not work before, and it did cause disruption, we reverted the change to the keepers.
