Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"IPv6 communication over VPC peering" PR broke module functionality without IPv6 specified #103

Open
adziura-ledger opened this issue Oct 1, 2024 · 1 comment
Labels
bug 🐛 An issue with the system

Comments

@adziura-ledger
Copy link

Describe the Bug

When you don't have IPv6 cidr specified for VPC module will not work because of this change
data.aws_vpc.requester[*].ipv6_cidr_block returns list with one empty element, and length will be always > 0
same for accepter
Changes introduced in PR #101

Expected Behavior

No changes if IPv6 CIDRs not defined.

Steps to Reproduce

Apply module (starting from version 0.20.1) for VPCs without IPv6 CIDRs defined.

Screenshots

No response

Environment

No response

Additional Context

No response

@adziura-ledger adziura-ledger added the bug 🐛 An issue with the system label Oct 1, 2024
@adziura-ledger adziura-ledger changed the title IPv6 communication over VPC peering PR broke module functionality without IPv6 specified "IPv6 communication over VPC peering" PR broke module functionality without IPv6 specified Oct 1, 2024
@NathanBaulch
Copy link

This also broke my ipv6-less VPC deployment with:

│ Error: "" is not a valid CIDR block: invalid CIDR address:
│
│   with module.peering.aws_route.accepter_ipv6[0],
│   on .terraform\modules\peering\accepter.tf line 128, in resource "aws_route" "accepter_ipv6":
│  128:   destination_ipv6_cidr_block = local.requester_ipv6_cidr_block_associations[count.index % local.requester_ipv6_cidr_block_associations_count]["cidr_block"]

Downgrading to v0.20.0 for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system
Projects
None yet
Development

No branches or pull requests

2 participants